Comments on: Using checklists for code review https://blog.beanbaginc.com/2013/04/24/using-checklists-for-code-review/ Updates from the makers of Review Board Thu, 18 Dec 2014 11:28:48 +0000 hourly 1 https://wordpress.org/?v=6.2.14 By: Practicing effective self-review | Beanbag Blog https://blog.beanbaginc.com/2013/04/24/using-checklists-for-code-review/#comment-16 Mon, 01 Dec 2014 23:01:25 +0000 http://blog.rbcommons.com/?p=140#comment-16 […] Using checklists for code review […]

]]>
By: David Trowbridge https://blog.beanbaginc.com/2013/04/24/using-checklists-for-code-review/#comment-13 Thu, 03 Oct 2013 22:27:00 +0000 http://blog.rbcommons.com/?p=140#comment-13 In reply to Tom Moore.

Felix’s project produced a prototype but was not actually usable. We have another student this fall working on taking things from prototype to production.

]]>
By: Tom Moore https://blog.beanbaginc.com/2013/04/24/using-checklists-for-code-review/#comment-12 Tue, 01 Oct 2013 16:38:00 +0000 http://blog.rbcommons.com/?p=140#comment-12 In reply to trowbrds.

Is there an update on this checklist extension? The last information I have been able to find is 5 months old.

]]>
By: trowbrds https://blog.beanbaginc.com/2013/04/24/using-checklists-for-code-review/#comment-11 Thu, 25 Apr 2013 22:45:00 +0000 http://blog.rbcommons.com/?p=140#comment-11 In reply to Issa Fram.

I’m a big fan of incorporating linting and other static analysis into the process, too. A lot of the items that I check at code review time are the ones which are harder to automate. The tooling for static analysis are improving every day, though, so I’m looking forward to the day when I only have to argue about the high level concepts and can let a computer find all the bugs.

]]>
By: trowbrds https://blog.beanbaginc.com/2013/04/24/using-checklists-for-code-review/#comment-10 Thu, 25 Apr 2013 22:42:00 +0000 http://blog.rbcommons.com/?p=140#comment-10 In reply to Aaron Kimball.

We participate in a bunch of student projects courses, and Felix Sung from MIT is currently working on building an extension that would let users create and use checklists inside Review Board. We can’t guarantee any kind of timeframe for when it will be ready, but as you might expect, this is something that I’m pretty excited about myself, too!

]]>
By: trowbrds https://blog.beanbaginc.com/2013/04/24/using-checklists-for-code-review/#comment-9 Thu, 25 Apr 2013 22:39:00 +0000 http://blog.rbcommons.com/?p=140#comment-9 In reply to Arnor Heidar Sigurdsson.

We do a lot of upfront design for new features, but a lot of the time we’re making incremental improvements to existing UIs. If we’re just adding a new check-box to an existing page, it probably doesn’t need a ton of design work (it’s faster to just write the code than it is to make a mock-up). Since I’m using these at the time of code review (as opposed to at design phase), those are the sorts of changes where I pull out my limited “visual design” checklist.

]]>
By: Issa Fram https://blog.beanbaginc.com/2013/04/24/using-checklists-for-code-review/#comment-8 Thu, 25 Apr 2013 19:08:00 +0000 http://blog.rbcommons.com/?p=140#comment-8 Or you could automated the checklist in your build…TFS Build Workflow like a boss with custom activities.

]]>
By: Pierre Rasmussen https://blog.beanbaginc.com/2013/04/24/using-checklists-for-code-review/#comment-7 Thu, 25 Apr 2013 08:35:00 +0000 http://blog.rbcommons.com/?p=140#comment-7 Great post! The best part is your own reflection “I find it incredibly difficult and error prone for me to read through code once” and how you use that learning to improve your own skills.

Several studies (google it) shows that not more than 150-200 lines of code should be reviewed per hour, becuse the mind starts to loose foucs.

I only use mentally checklists today but I will definitely give it a try.

]]>
By: Sergei https://blog.beanbaginc.com/2013/04/24/using-checklists-for-code-review/#comment-6 Thu, 25 Apr 2013 03:02:00 +0000 http://blog.rbcommons.com/?p=140#comment-6 We have checklists. They work for us. They also have educational value, and they can also make code reviews easier, because you know what to look for, and people know what you are going to look for.

]]>
By: Arnor Heidar Sigurdsson https://blog.beanbaginc.com/2013/04/24/using-checklists-for-code-review/#comment-5 Thu, 25 Apr 2013 02:24:00 +0000 http://blog.rbcommons.com/?p=140#comment-5 Good idea around having a CR checklist. Probably very helpful for people who are new to doing CRs. I think I appreciate the technical lists more than the very limited design questions.

If you are thinking about the design part of things during a CR, your process can probably be improved. CRs should be about code that implements existing designs/ideas etc and doesn’t actually introduce big things. However, sometimes edge cases are only surfaced when you are debugging/working on code, in wich case adding UI elements/user facing stuff that hasn’t been designed may make sense.

Oh, I just realized that you mostly work on OS.. in which I’ve heard nobody designs anything up front (or not much), just writes code – I can see these lists making sense in that context.

]]>